GOATS-971: add version checker in goats run #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
+ Coverage 78.91% 79.06% +0.15%
==========================================
Files 264 266 +2
Lines 8390 8523 +133
Branches 490 493 +3
==========================================
+ Hits 6621 6739 +118
- Misses 1680 1694 +14
- Partials 89 90 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davner
reviewed
Oct 16, 2025
miguelgomezgomez
force-pushed
the
GOATS-971/add-version-checker-in-goats-run
branch
2 times, most recently
from
b073ac4 to
5311592
Compare
davner
approved these changes
Oct 21, 2025
There was a problem hiding this comment.
Thanks for addressing the major feedback!
I’ve left a few revisions that need to be addressed before merging.
Also, I pushed a cleanup commit to remove some outdated --remote-data tests. Please make sure to pull to update your branch. Don't worry about rebasing or squashing my commit.
Great work overall.
miguelgomezgomez
force-pushed
the
GOATS-971/add-version-checker-in-goats-run
branch
from
2d06269 to
2319ccf
Compare
miguelgomezgomez
deleted the
GOATS-971/add-version-checker-in-goats-run
branch
miguelgomezgomez
restored the
GOATS-971/add-version-checker-in-goats-run
branch
miguelgomezgomez
deleted the
GOATS-971/add-version-checker-in-goats-run
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesusing the PR number.